Skip to content

[RF] emit warning for dupe arguments in RooCmdConfig process #20094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2025
Merged

[RF] emit warning for dupe arguments in RooCmdConfig process #20094

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95987b2
[RF] emit warning for dupe arguments in RooCmdConfig process
ferdymercury Oct 13, 2025
7f345be
[RF] clangf
ferdymercury Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions roofit/roofitcore/src/RooCmdConfig.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ arguments and dependencies between arguments.
#include <ROOT/StringUtils.hxx>

#include <iostream>

#include <set>

namespace {

Expand Down Expand Up @@ -286,18 +286,24 @@ void RooCmdConfig::print() const
}
}



////////////////////////////////////////////////////////////////////////////////
/// Process given list with RooCmdArgs
/// Emit warning if duplicate arguments

bool RooCmdConfig::process(const RooLinkedList& argList)
{
bool ret(false) ;
for(auto * arg : static_range_cast<RooCmdArg*>(argList)) {
ret |= process(*arg) ;
}
return ret ;
bool ret(false);
std::set<std::string> opcodes;
for (auto *arg : static_range_cast<RooCmdArg *>(argList)) {
auto opc = arg->opcode();
if (opc && opcodes.find(opc) != opcodes.end()) {
coutW(InputArguments) << _name << " WARNING: argument " << opc << " is duplicated" << std::endl;
} else if (opc) {
opcodes.insert(opc);
}
ret |= process(*arg);
}
return ret;
}


Expand Down
Loading