[RF] Correctly normalize RooSimultaneous when projecting over data #20441
+62
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a8ef8b0, any RooAbsPdf that makes a prediction for the expected number of events will use this prediction for the normalization when plotting. This made is more meaningful to compare models with data because the model normalization was not automatically scaled to match the data. However, it also broke plots with projections of RooSimultaneous pdfs over data, because the temporary RooAddPdf that is created in this case did not use coefficients that were scaled to the actual dataset, but to unity. Correctly normalizing to the sum of entries in the dataset fixes this problem. A unit test is also implemented. Closes root-project#20383.
Avoid warning about duplicate command arguments by removing old arguments when overriding them.
guitargeek
force-pushed
the
issue-20383
branch
from
885e443 to
a1c38f9
Compare
Test Results 22 files 22 suites 3d 15h 49m 38s ⏱️ For more details on these failures, see this check. Results for commit a1c38f9. |
lmoneta
approved these changes
Nov 17, 2025
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
Thank you Jonas to fix this imporatnt issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a8ef8b0, any RooAbsPdf that makes a prediction for the expected number of events will use this prediction for the normalization when plotting.
This made is more meaningful to compare models with data because the model normalization was not automatically scaled to match the data.
However, it also broke plots with projections of RooSimultaneous pdfs over data, because the temporary RooAddPdf that is created in this case did not use coefficients that were scaled to the actual dataset, but to unity. Correctly normalizing to the sum of entries in the dataset fixes this problem.
A unit test is also implemented.
Closes #20383.