[RF] Return reference to actual RooAbsReal in RooPolyVar::x() getter
#20442
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like in any other getter for the inputs of RooFit functions, the `RooPolyVar::x()` getter should return the underlying RooAbsReal, instead of the internal proxy. Closes root-project#20293.
1 task
Test Results 22 files 22 suites 3d 22h 25m 25s ⏱️ For more details on these failures, see this check. Results for commit 116d20f. |
lmoneta
approved these changes
Nov 17, 2025
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
I agree it is better being consistent. Can this be a backwaerd compatibility issue for somebody or is this function just used only internally?
Contributor
Author
|
Thanks for the review! This interface was only introduced in ROOT 6.36 with 96e023b, and so far only used internally. So I think it's not too late to change it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like in any other getter for the inputs of RooFit functions, the
RooPolyVar::x()getter should return the underlying RooAbsReal, instead of the internal proxy.Closes #20293.
Thanks to @Phmonski for noticing this!