[cmake] enable/disable jsroot in jupyter [6.38] #20462
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now jsroot functionality in jupyter depends on TWebCanvas functionality. But it is not compiled when -Dwebgui=off is configured. So change default notebook behavior depending on that configuration Resolves root-project#20450
Test Results 22 files 22 suites 3d 17h 55m 33s ⏱️ For more details on these failures, see this check. Results for commit 65e29bb. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now jsroot functionality in jupyter depends on
TWebCanvas functionality. But it is not compiled
when -Dwebgui=off is configured. So change default notebook behavior depending on that configuration
Backport of #20461