[hist] Implement calling TSpectrum2 and TSpectrum3 Background from TH2/3 #20479
+212
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
force-pushed
the
tspec2back
branch
from
16d7617 to
23c22c3
Compare
…2 or TH3 Since it's implemented for the 1D version, and for the 2D versions you can call it via raw pointers but not directly via TH2 or TH3. Functions were marked before as to-do, so no one could be calling them directly since they were already doing nothing and raising error. Hence, function signature and name were adapted to match the 2D and 3D needed parameters. Since these are legacy classes, the code from the implemented 1D version was copy-pasted and adapted, but no code modernization was performed, such as avoiding new/delete etc. Fixes https://root-forum.cern.ch/t/tspectrum2-bac-error-function-not-yet-implemented/64427 I've been hit myself with this, too.
ferdymercury
force-pushed
the
tspec2back
branch
from
23c22c3 to
080daba
Compare
Test Results 21 files 21 suites 3d 12h 25m 27s ⏱️ Results for commit 080daba. |
Member
|
Thanks for contributing to reduce the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Since it's implemented for the 1D version, and for the 2D/3D versions you can call it via raw pointers but not directly via TH2 or TH3.
Functions were marked before as to-do, so no one could be calling them directly since they were already doing nothing and raising error. Hence, function signature and name were adapted to match the 2D and 3D needed parameters. Since these are legacy classes, the code from the implemented 1D version was copy-pasted and adapted, but no code modernization was performed, such as avoiding new/delete etc or clang-formatting.
Fixes https://root-forum.cern.ch/t/tspectrum2-bac-error-function-not-yet-implemented/64427
I've been hit myself with this, too.
Checklist: