Skip to content

[main] rootls: fix/improve recursive printing #20507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[main] rootls: fix/improve recursive printing #20507

wants to merge 1 commit into from
+39 −11

Conversation

@silverweed
Copy link
Contributor

@silverweed silverweed commented Nov 25, 2025

The current algorithm didn't properly handle certain cases when the -r flag is used (namely, directories were not printed in a newline)

Example before:

dir  hprof  hpx  hpxpy
tof
  h0_0N  h0_1N  h0_2N  h0_3N  h0_4N  h0_5N  h0_6N  h0_7N  h0_8N  h0_9N  h1_0N  h1_1N  h1_2N  h1_3N  h1_4N  h1_5N  h1_6N  h1_7N  h1_8N  h1_9N  plane0
    h0_10N  h0_11N  h0_12N  h0_13N  h0_14N  h0_15N  h0_16N  h0_17N  h0_18N  h0_19N  h0_20N  h0_21N  h0_22N  h0_23N  h0_24N  h0_25N  h0_26N  h0_27N  h0_28N  h0_29N  h0_30N  h0_31N  h0_32N  h0_33N
    h0_34N  h0_35N  h0_36N  h0_37N  h0_38N  h0_39N  h0_40N  h0_41N  h0_42N  h0_43N  h0_44N  h0_45N  h0_46N  h0_47N  h0_48N  h0_49N
plane1
    h1_10N  h1_11N  h1_12N  h1_13N  h1_14N  h1_15N  h1_16N  h1_17N  h1_18N  h1_19N  h1_20N  h1_21N  h1_22N  h1_23N  h1_24N  h1_25N  h1_26N  h1_27N  h1_28N  h1_29N  h1_30N  h1_31N  h1_32N  h1_33N
    h1_34N  h1_35N  h1_36N  h1_37N  h1_38N  h1_39N  h1_40N  h1_41N  h1_42N  h1_43N  h1_44N  h1_45N  h1_46N  h1_47N  h1_48N  h1_49N

After:

dir  hprof  hpx  hpxpy
tof
  h0_0N  h0_1N  h0_2N  h0_3N  h0_4N  h0_5N  h0_6N  h0_7N  h0_8N  h0_9N  h1_0N  h1_1N  h1_2N  h1_3N  h1_4N  h1_5N  h1_6N  h1_7N  h1_8N  h1_9N
  plane0
    h0_10N  h0_11N  h0_12N  h0_13N  h0_14N  h0_15N  h0_16N  h0_17N  h0_18N  h0_19N  h0_20N  h0_21N  h0_22N  h0_23N  h0_24N  h0_25N  h0_26N  h0_27N  h0_28N  h0_29N  h0_30N  h0_31N  h0_32N  h0_33N
    h0_34N  h0_35N  h0_36N  h0_37N  h0_38N  h0_39N  h0_40N  h0_41N  h0_42N  h0_43N  h0_44N  h0_45N  h0_46N  h0_47N  h0_48N  h0_49N
  plane1
    h1_10N  h1_11N  h1_12N  h1_13N  h1_14N  h1_15N  h1_16N  h1_17N  h1_18N  h1_19N  h1_20N  h1_21N  h1_22N  h1_23N  h1_24N  h1_25N  h1_26N  h1_27N  h1_28N  h1_29N  h1_30N  h1_31N  h1_32N  h1_33N
    h1_34N  h1_35N  h1_36N  h1_37N  h1_38N  h1_39N  h1_40N  h1_41N  h1_42N  h1_43N  h1_44N  h1_45N  h1_46N  h1_47N  h1_48N  h1_49N

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed self-assigned this Nov 25, 2025
@silverweed silverweed requested a review from pcanal as a code owner November 25, 2025 10:39
@silverweed silverweed requested a review from bellenot as a code owner November 25, 2025 10:46
@silverweed silverweed mentioned this pull request Nov 25, 2025
Open
@silverweed
[main] rootls: improve recursive printing
2d8b749 
The current algorithm didn't properly handle certain cases when the -r
flag is used (namely, directories were not printed in a newline)
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

Test Results

    20 files      20 suites   3d 11h 28m 33s ⏱️
 3 770 tests  3 770 ✅ 0 💤 0 ❌
73 809 runs  73 809 ✅ 0 💤 0 ❌

Results for commit 2d8b749.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpiparo dpiparo dpiparo approved these changes

@jblomer jblomer Awaiting requested review from jblomer

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

Assignees

@silverweed silverweed

Labels

Main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@silverweed @dpiparo