[RF] Fix codegen of RooMultiVarGaussian #20518
Open
+40
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoneta
approved these changes
Nov 25, 2025
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
Thanks Jonas for the fix!
The codegen implementation for this class was broken because the function only took one template parameter, which resulted in overload resolution failure when the passed argument types were different. This is fixed now, and a unit test is added to prevent future regressions. Also, a workaround around a Clad issue is removed from the tests, and the tolerance parameter of some tests is adjusted, because changing a prior test had an effect on the random number generation of the Landau tests.
guitargeek
force-pushed
the
roomultivargaussian_codegen
branch
from
36f6400 to
9caaa47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codegen implementation for this class was broken because the function only took one template parameter, which resulted in overload resolution failure when the passed argument types were different.
This is fixed now, and a unit test is added to prevent future regressions.
Also, a workaround around a Clad issue is removed from the tests, and the tolerance parameter of some tests is adjusted, because changing a prior test had an effect on the random number generation of the Landau tests.
FYI, @TomasDado