Skip to content

[test] Make all tests green when using a minimal build #20711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 5 commits into from
Dec 15, 2025
Merged

[test] Make all tests green when using a minimal build #20711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4bdf49e
[test] Exclude processExecutorH1Test if xrootd is not present
dpiparo Dec 14, 2025
59e0d67
[test] Migrate execOptionList to CTest and exclude if minimal=ON
dpiparo Dec 14, 2025
ceaf658
[test] Disable formula1 tutorial if minimal=ON
dpiparo Dec 14, 2025
4732db3
[test] Exclude Python tests if Python not found
dpiparo Dec 14, 2025
94c0e70
[test] Do not run TTabCom tests if minimal=ON
dpiparo Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/rint/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
# For the licensing terms see $ROOTSYS/LICENSE.
# For the list of contributors see $ROOTSYS/README/CREDITS.

ROOT_ADD_GTEST(TTabComTests TTabComTests.cxx LIBRARIES Rint)
if(NOT minimal)
Copy link
Member

@pcanal pcanal Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really the best test? What 'feature(s)' is missing that make the test not working?

ROOT_ADD_GTEST(TTabComTests TTabComTests.cxx LIBRARIES Rint)
endif()
ROOT_ADD_GTEST(TRintTests TRintTests.cxx LIBRARIES Rint)

5 changes: 5 additions & 0 deletions roottest/root/meta/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,9 @@ ROOTTEST_ADD_TEST(hello_ROOT_C
OUTREF hello_ROOT_C_${libsuf}.ref
FIXTURES_REQUIRED root-meta-hello_ROOT-fixture)

if(NOT minimal)
Copy link
Member

@pcanal pcanal Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really the best test? What 'feature(s)' is missing that make the test not working?

ROOTTEST_ADD_TEST(optionList
MACRO optionList.cxx)
endif()

ROOTTEST_ADD_TESTDIRS()
3 changes: 0 additions & 3 deletions roottest/root/meta/execOptionList.ref
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion roottest/root/meta/execOptionList.cxx → roottest/root/meta/optionList.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ int check(TDataMember *d, UInt_t i, const char *name, Long_t expected) {
}
}

int execOptionList() {
int optionList() {
gSystem->Setenv("DISPLAY",""); // Avoid spurrious warning when libGui is loaded.

auto c = TClass::GetClass("TGTextEntry");
Expand Down
23 changes: 12 additions & 11 deletions roottest/root/multicore/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,18 @@ ROOTTEST_ADD_TEST(SequentialExecutor
FIXTURES_REQUIRED root-multicore-tSequentialExecutor-fixture)

if(NOT MSVC AND NOT dev)
ROOTTEST_GENERATE_EXECUTABLE(processExecutorH1Test
tProcessExecutorH1Test.cpp
COMPILE_FLAGS "-I${ROOTSYS}/tutorials/legacy/multicore"
LIBRARIES ROOT::MultiProc ROOT::Core ROOT::Net ROOT::TreePlayer ROOT::Tree ROOT::RIO ROOT::Hist ROOT::Gpad ROOT::Graf
FIXTURES_SETUP root-multicore-processExecutorH1Test-fixture)

ROOTTEST_ADD_TEST(processExecutorH1Test
EXEC ${CMAKE_CURRENT_BINARY_DIR}/processExecutorH1Test
OUTREF tProcessExecutorH1Test.ref
FIXTURES_REQUIRED root-multicore-processExecutorH1Test-fixture)

if(xrootd)
ROOTTEST_GENERATE_EXECUTABLE(processExecutorH1Test
tProcessExecutorH1Test.cpp
COMPILE_FLAGS "-I${ROOTSYS}/tutorials/legacy/multicore"
LIBRARIES ROOT::MultiProc ROOT::Core ROOT::Net ROOT::TreePlayer ROOT::Tree ROOT::RIO ROOT::Hist ROOT::Gpad ROOT::Graf
FIXTURES_SETUP root-multicore-processExecutorH1Test-fixture)

ROOTTEST_ADD_TEST(processExecutorH1Test
EXEC ${CMAKE_CURRENT_BINARY_DIR}/processExecutorH1Test
OUTREF tProcessExecutorH1Test.ref
FIXTURES_REQUIRED root-multicore-processExecutorH1Test-fixture)
endif()
ROOTTEST_GENERATE_EXECUTABLE(processExecutorTreeTest
tProcessExecutorTreeTest.cpp
LIBRARIES MultiProc Core Net TreePlayer Tree RIO Hist
Expand Down
24 changes: 13 additions & 11 deletions roottest/root/ntuple/atlas-datavector/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,17 @@ ROOTTEST_ADD_TEST(read
# instantiation done by the Python bindings was leading to a faulty behaviour:
# the user-provided class template "AtlasLikeDataVector<CustomStruct>" does not
# correspond to what the compiler sees, so we need to inject this information.
ROOT_ADD_PYUNITTEST(
rentry_getptr
rentry_getptr.py
GENERIC
PYTHON_DEPS pytest
FIXTURES_REQUIRED atlas_datavector_write_done)
if(ROOT_pyroot_FOUND)
ROOT_ADD_PYUNITTEST(
rentry_getptr
rentry_getptr.py
GENERIC
PYTHON_DEPS pytest
FIXTURES_REQUIRED atlas_datavector_write_done)

ROOT_ADD_PYUNITTEST(
template_instantiation
template_instantiation.py
GENERIC
PYTHON_DEPS pytest)
ROOT_ADD_PYUNITTEST(
template_instantiation
template_instantiation.py
GENERIC
PYTHON_DEPS pytest)
endif()
7 changes: 7 additions & 0 deletions tutorials/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,12 @@ else()
list(APPEND root7_veto io/ntuple/ntpl011_global_temperatures.C)
endif()

#---These do not run with minimal
if(minimal)
Copy link
Member

@pcanal pcanal Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really the best test? What 'feature' is missing that make the test not working?

set(minimal_veto visualisation/graphics/formula1.C) # relies on unstable ROOT::Detail::HasBeenDeleted
endif()


#---These ones are disabled !!! ------------------------------------
set(extra_veto
legacy/benchmarks.C
Expand Down Expand Up @@ -514,6 +520,7 @@ set(all_veto hsimple.C
${spectrum_veto}
${dataframe_veto}
${davix_veto}
${minimal_veto}
)

file(GLOB_RECURSE tutorials RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.C)
Expand Down
Loading