Skip to content

Renormalize fitted parameters error when using the option "W" in TH1::Fit #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Renormalize fitted parameters error when using the option "W" in TH1::Fit #5114

merged 1 commit into from
Mar 10, 2020

Conversation

@lmoneta
Copy link
Member

@lmoneta lmoneta commented Mar 9, 2020

Renormalize the fitted errors in case the histogram has no error (i.e. when using the fit option "W")
In this case the parameter errors are corrected using the obtained chi2 value

error = error* sqrt( chi2/(ndf-1)

  • Add in the documentation also option "MULTI" (Multinomial likelihood fit)

@lmoneta
- Renormalize fitted parameters error when using the option "W" also …
c46e295 
…for the histogram fit

- Update the documentation
 - add also option "MULTI" in the doc
@phsft-bot
Copy link

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on mac1014/cxx17.
See console output.

Errors:

  • FAILED: geom/geom/CMakeFiles/Geom.dir/src/TGeoTessellated.cxx.o
  • /build/jenkins/workspace/root-pullrequests-build/root/geom/geom/src/TGeoTessellated.cxx:385:23: error: implicit instantiation of undefined template 'std::__1::array<std::__1::vector<int, std::__1::allocator<int> >, 1000000>'

@phsft-bot
Copy link

Build failed on windows10/cxx14.
See console output.

Errors:

  • C:\build\workspace\root-pullrequests-build\root\geom\geom\src\TGeoTessellated.cxx(385,67): error C2027: use of undefined type 'std::array<CellVec_t,1000000>' [C:\build\workspace\root-pullrequests-build\build\geom\geom\Geom.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\geom\geom\src\TGeoTessellated.cxx(393,56): error C3536: 'grid': cannot be used before it is initialized [C:\build\workspace\root-pullrequests-build\build\geom\geom\Geom.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\geom\geom\src\TGeoTessellated.cxx(394,40): error C2065: 'ivert': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\geom\geom\Geom.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\geom\geom\src\TGeoTessellated.cxx(395,28): error C2065: 'ivert': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\geom\geom\Geom.vcxproj]
  • C:\build\workspace\root-pullrequests-build\root\geom\geom\src\TGeoTessellated.cxx(408,18): error C2541: 'delete': cannot delete objects that are not pointers [C:\build\workspace\root-pullrequests-build\build\geom\geom\Geom.vcxproj]

@lmoneta
Copy link
Member Author

lmoneta commented Mar 10, 2020

@phsft-bot build!

@phsft-bot
Copy link

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@lmoneta lmoneta merged commit 4cb2b78 into root-project:master Mar 10, 2020
@lmoneta lmoneta deleted the histogram_fitting_optionW branch March 10, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lmoneta lmoneta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lmoneta @phsft-bot