Skip to content

Use network layer from RSSwiftNetworking 1.1.0 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2022
Merged

Use network layer from RSSwiftNetworking 1.1.0 #200

merged 3 commits into from
Sep 1, 2022

Conversation

@glm4
Copy link
Collaborator

@glm4 glm4 commented Aug 2, 2022

Description:

  • Migrate the existing network layer code to RSSwiftNetworking.

Notes:

  • The new library still needs work, but it provides the same capabilities we previously had.

Tasks:

Risk:

  • High

Preview:

  • N/A

@glm4 glm4 requested a review from a user August 2, 2022 19:39
kstoletniy
kstoletniy approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@kstoletniy kstoletniy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

LetoFranco
LetoFranco approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@LetoFranco LetoFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment in one of the files, but its look great to me!

@glm4 glm4 changed the base branch from master to main August 16, 2022 19:40
@glm4 glm4 changed the title Use network layer from RSSwiftNetworking 1.0.1 Use network layer from RSSwiftNetworking 1.1.0 Aug 31, 2022
@glm4 glm4 merged commit 6311f2e into main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pMalvasio pMalvasio pMalvasio approved these changes

@CamilaMoscatelli CamilaMoscatelli Awaiting requested review from CamilaMoscatelli CamilaMoscatelli is a code owner

@mato2593 mato2593 Awaiting requested review from mato2593

@germanStabile germanStabile Awaiting requested review from germanStabile germanStabile is a code owner

@fpiruzi fpiruzi Awaiting requested review from fpiruzi fpiruzi is a code owner

@LeandroHiga LeandroHiga Awaiting requested review from LeandroHiga

@danialepaco danialepaco Awaiting requested review from danialepaco

@fconelli fconelli Awaiting requested review from fconelli

@DaegoDev DaegoDev Awaiting requested review from DaegoDev

@JUNIOR140889 JUNIOR140889 Awaiting requested review from JUNIOR140889

@SofiaCantero24 SofiaCantero24 Awaiting requested review from SofiaCantero24

+2 more reviewers

@LetoFranco LetoFranco LetoFranco approved these changes

@kstoletniy kstoletniy kstoletniy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@glm4 @pMalvasio @LetoFranco @kstoletniy