Fix/login error redirection #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glm4
requested review from
CamilaMoscatelli,
P0nj4,
aguscha333,
fernandatoledo,
mato2593,
mjurfest,
pMalvasio and
ximenaperez
ximenaperez
approved these changes
Apr 24, 2018
grilix
reviewed
Apr 24, 2018
.codeclimate.yml
Outdated
|
|
||
| plugins: | ||
| swiftlint: | ||
| enabled: true No newline at end of file |
There was a problem hiding this comment.
isn't this the default? I don't see the purpose of this file
There was a problem hiding this comment.
@MaicolBen You say that enabling the plugin in the CC dashboard is the same as this?
There was a problem hiding this comment.
When you add the project to CC, it already runs swiftlint, this file is for disabling or customizing the plugin checks.
There was a problem hiding this comment.
Ok, I will delete this file and leave the Swiftlint pluging option enabled on CC.
glm4
force-pushed
the
fix/login_error_redirection
branch
from
9c2ec84 to
710ccaa
Compare
glm4
force-pushed
the
fix/login_error_redirection
branch
from
710ccaa to
173b542
Compare
mjurfest
approved these changes
Apr 24, 2018
CamilaMoscatelli
approved these changes
Apr 24, 2018
|
@glm4 Add the CC badge to the readme |
mato2593
approved these changes
Apr 24, 2018
aguscha333
approved these changes
Apr 25, 2018
pMalvasio
approved these changes
Apr 25, 2018
MaicolBen
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76 and #77 by:
-Adding CodeClimate config file with swiftlint plugin enabled.
-Adding clear instructions for automatic logout feature about redirecting the user.
Reviewers