Remove sass-rails gem and use cssbundling and dartsass instead #807
Conversation
andresg4
requested review from
a team,
JulianPasquale,
PerezIgnacio and
santib
| gem 'sass-rails', '~> 6.0.0' | ||
| gem 'sendgrid', '~> 1.2.4' | ||
| gem 'sprockets', '~> 4.2.1' | ||
| gem 'sprockets-rails', '~> 3.5', '>= 3.5.2' |
There was a problem hiding this comment.
Why is this changing from sprockets to sprokets-rails?
There was a problem hiding this comment.
if we keep the sprockets gem and remove the sass-rails, we get this error 'require': cannot load such file -- sprockets/railtie. Replacing it with the sprockets-rails one solves it. I'm not really sure why this happens
There was a problem hiding this comment.
Would be nice to understand why and what is the impact of this change. I assume we're good, but let's validate it doesn't have any negative impact
There was a problem hiding this comment.
just in case, sprockets-rails was already being installed as a dependency on sass-rails. https://github.com/rootstrap/rails_api_base/pull/807/files#diff-89cade48462044ee1b672dc5f4c3ec250fbd29effcd8932096a23c1283c6731fL571-L573
Basically our previous setup wasn't so good, that's the whole issue here. sprockets-rails is required for our app that we are using the traditional asset pipeline.
| "scripts": { | ||
| "build": "node esbuild.config.mjs" | ||
| "build": "node esbuild.config.mjs", | ||
| "build:css": "sass ./app/assets/stylesheets:./app/assets/builds --no-source-map --load-path=node_modules" |
There was a problem hiding this comment.
Shouldn't the build script run this as well? Maybe we can call this prebuild so it runs automatically?
There was a problem hiding this comment.
I think this was added by the cssbundling gem. I mean, the default behavior.
There was a problem hiding this comment.
Yeah, I'm just saying that would be nice to have something like
"scripts": {
"build": "yarn build:js && yarn build:css",
"build:js": "node esbuild.config.mjs",
"build:css": "sass ./app/assets/stylesheets:./app/assets/builds --no-source-map --load-path=node_modules"
}That way build runs both process. Or another option would be to rename the build:css script to prebuild so it's always executed when we call build. (I like the first option because it's more flexible tbh).
Anyway, if you want to keep it this way, we might need to add the build:css step to our Dockerfile.dev
andresg4
force-pushed
the
remove-sass-rails-gem
branch
from
6a6dd4a to
25a3a1d
Compare
6 participants
Board:
Description:
The
sass-railsgem is deprecated, in this PR we use cssbundling-rails and configuredartsasswith itNotes:
Tasks:
Risk:
Preview: