Alternative approach to compatibility #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ash
approved these changes
Jul 6, 2021
Collaborator
r-ash
left a comment
r-ash
left a comment
There was a problem hiding this comment.
Returning note but continuing with imjv looks like a good pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach to backward compatibility is more complete - we no longer try and get people using ajv but instead let them know they're missing out.
The imjv validator now (again) fairly silently passes where given new json schema versions and does not read nested schemas. Packages that on CRAN which rely on that behaviour are unaffected and we can upgrade the package. Once done we should follow up with dependencies though and let them know.
I've added a bit of docs to make the situation clear
See also master...mrc-2476-compat for net change against master
Fixes #38