-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller Manager should not crash when trying to start finalized or unconfigured controller #461
Merged
destogl
merged 2 commits into
ros-controls:master
from
destogl:cm-crash-on-finalized-controller
Sep 7, 2021
Merged
Controller Manager should not crash when trying to start finalized or unconfigured controller #461
destogl
merged 2 commits into
ros-controls:master
from
destogl:cm-crash-on-finalized-controller
Sep 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
destogl
commented
Jul 13, 2021
•
edited
Loading
edited
- Avoid crashing of controller manager when trying to start a controller in finalized or unconfigured state.
I need some help with tests. I am not really sure why they are failing. |
destogl
changed the title
Controller Manager should not crash when trying to start finalized and unconfigured controller
Controller Manager should not crash when trying to start finalized or unconfigured controller
Jul 13, 2021
destogl
force-pushed
the
cm-crash-on-finalized-controller
branch
from
September 6, 2021 16:00
370d65d
to
dc227bc
Compare
…r in finalized or unconfigured state.
destogl
force-pushed
the
cm-crash-on-finalized-controller
branch
from
September 6, 2021 16:03
dc227bc
to
d422f7c
Compare
destogl
commented
Sep 6, 2021
We should also add tests for |
bmagyar
approved these changes
Sep 7, 2021
@Mergifyio backport foxy |
Command
|
destogl
added a commit
to destogl/ros2_control
that referenced
this pull request
Sep 7, 2021
… unconfigured controller (ros-controls#461)
pac48
pushed a commit
to pac48/ros2_control
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.