-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Add PID controller 🎉 #434
🚀 Add PID controller 🎉 #434
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 46.73% 47.33% +0.60%
==========================================
Files 40 40
Lines 3640 3640
Branches 1718 1718
==========================================
+ Hits 1701 1723 +22
+ Misses 749 725 -24
- Partials 1190 1192 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
This pull request is in conflict. Could you fix it @destogl? |
ee50af7
to
5120bb3
Compare
8ec9d54
to
c094b27
Compare
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
05607da
to
2f7bf48
Compare
… be always updated. Enalbe option for Angle wraparound and add templates for the tests.
Can we backport this to iron and humble? |
(cherry picked from commit 038a547)
(cherry picked from commit 038a547)
(cherry picked from commit 038a547)
Proposal for a new controller that provides PID functionality.
The controller can be used stand-alone, in a chain.
Measured states can be provided through the topic or state interface, depening on the concrete control arch.
For example, if you are having an external estimator, using topic might be eaiser at first then full integration into ros2_control.
The PR depends the following changes:
Looking forward for your feedback!
Testing dependencies: