Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROS-O] do not force old c++11 standard #239

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[ROS-O] do not force old c++11 standard #239

merged 1 commit into from
Sep 18, 2023

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Oct 4, 2022

log4cxx requires c++17 these days and explicitly setting an old standard breaks it.

@JWhitleyWork
Copy link

Note: Noetic (the target for the main branch) is specifically built with support for only C++14. Removing these lines is OK to force a newer standard but it's not officially supported to use it with C++17.

@JWhitleyWork JWhitleyWork merged commit 69dbf6c into ros-drivers:main Sep 18, 2023
@v4hn v4hn mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v4hn @JWhitleyWork