Qt Creator 14 #506
Merged
Qt Creator 14 #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-rauch
force-pushed
the
14
branch
6 times, most recently
from
bb35fbb
to
df240af
Compare
|
LGTM |
|
At some point we will need to update this to leverage the active device for running these command to make this work when using other Qt Creator features like docker device. |
Levi-Armstrong
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the usual internal API updates for the next major version of Qt Creator and reworks how the environment variables from sources workspaces are gathered. Previously we used a process that was passed between functions to store the environment. Now we explicitly pass a
QProcessEnvironmentbetween functions and only create and run a process when required. Fixes #500.