Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calibration yaml formatting #580

Merged

Conversation

DavidTorresOcana
Copy link
Contributor

This PR fixes formatting of calibration tool yaml.

camera_model -> distortion_model

This issue was introduced in #440

@DavidTorresOcana
Copy link
Contributor Author

It would be nice if anybody could merge this PR onto Noetic and ROS2

This was referenced Aug 2, 2020
@JWhitleyWork
Copy link
Collaborator

Yeah, looks like it was a copy/paste error. Thanks for the fix!

@JWhitleyWork JWhitleyWork merged commit d3bfa86 into ros-perception:melodic Aug 19, 2020
JWhitleyWork pushed a commit that referenced this pull request Aug 19, 2020
JWhitleyWork pushed a commit that referenced this pull request Aug 19, 2020
Co-authored-by: David Torres Ocaña <david.torres.ocana@gmail.com>
wep21 pushed a commit to wep21/image_pipeline that referenced this pull request Oct 17, 2021
)

Co-authored-by: David Torres Ocaña <david.torres.ocana@gmail.com>
JWhitleyWork pushed a commit that referenced this pull request Nov 11, 2021
Co-authored-by: David Torres Ocaña <david.torres.ocana@gmail.com>
JWhitleyWork pushed a commit that referenced this pull request Apr 14, 2022
Co-authored-by: David Torres Ocaña <david.torres.ocana@gmail.com>
@parameciumvance
Copy link

Why is this fix not updated to melodic release?
I mean, when apt install ros-melodic-camera-calibration, I get version 1.15.0 rather than 1.15.1

@JWhitleyWork
Copy link
Collaborator

JWhitleyWork commented Jul 13, 2022

@parameciumvance Thanks for bringing this up. There is definitely some funny stuff going on with the melodic rosdistro entry. Looking into fixing it now.

@JWhitleyWork
Copy link
Collaborator

Something must have gone wrong when I tried to make the Bloom PR for the 1.15.1 release and I apparently didn't fix it. This has now been corrected in a new 1.15.2 release (see this PR) which also fixes the indigo references. Once this PR is merged and the next Melodic package sync happens, the issue should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants