[windows][master] some more header inclusion and MSVC build error fixes. #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyen
requested review from
bmagyar,
davetcoleman,
henningkayser,
jonbinney,
mikeferguson,
rhaschke and
v4hn
as code owners
seanyen
changed the title
v4hn
reviewed
Aug 21, 2019
moveit_planners/chomp/chomp_motion_planner/src/chomp_optimizer.cpp
Outdated
Show resolved
Hide resolved
|
@v4hn Thanks for the review. I updated the pull requests to address some feedback. |
rhaschke
reviewed
Aug 22, 2019
|
On Thu, Aug 22, 2019 at 11:05:37AM -0700, Robert Haschke wrote:
My key point is to avoid defines.
You do not avoid them, just move them to a compatibility header in (I guess) `moveit_core/compat`. ;)
1. rely on the developer to include them before the compat header when necessary
:/
2. or explicitly declare those required functions in the compat header.
This could be an option, although I can imagine different Unix standards might conflict here. ;-D
In either case you will still need `#ifdef`'s to distinguish between the includes.
So I do not see the merit of avoiding 1-3 defines in addition to the guarded includes.
|
|
Indeed, I would prefer this over `std::make_pair(static_cast<int>(index),0)`.
However, I'm not sure about the actual problem in Windows. Maybe `std::make_pair<int>()` is just not available as I assume...
I fear we might end up with `std::make_pair<int, int>(static_cast<int>(index), 0)` to address your concerns *and* fix the windows compiler issue. ;)
Let's wait for feedback from the author.
|
To be clear about this: In the code base we would just do: |
|
However, using the second option, there is nothing more to do.
This is true as long as you do not want to have compile-time (vs. link time) validation
that the specified function signature is actually correct for your system.
Usually people still include the host's headers to get error messages on signature mismatch.
But I guess we might be able to skip this.
|
added 2 commits
August 28, 2019 01:50
rhaschke
reviewed
Aug 30, 2019
Co-Authored-By: Robert Haschke <rhaschke@users.noreply.github.com>
rhaschke
approved these changes
Aug 30, 2019
|
Thanks for your patience 😉 |
|
Thanks @seanyen 👍 |
henningkayser
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
Nov 21, 2019
…eit#1636) * Fix header inclusion for Windows build. * replace random() with c++11 <random> usage.
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Feb 8, 2020
…eit#1636) * Fix header inclusion for Windows build. * replace random() with c++11 <random> usage.
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static_castforindexinplan_execution::PlanExecution::successfulTrajectorySegmentExecutionto avoid MSVC compiler error.constforSortBodies::operator()to avoid C3848 error by MSVC.<random>for portable random number generation.