-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop_requested_ flag clearing fix #2537
stop_requested_ flag clearing fix #2537
Conversation
Thanks for helping in improving MoveIt and open source robotics! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I was involved in testing this, so it looks good to me.
Codecov Report
@@ Coverage Diff @@
## master #2537 +/- ##
==========================================
+ Coverage 60.20% 60.23% +0.04%
==========================================
Files 351 351
Lines 26485 26485
==========================================
+ Hits 15942 15951 +9
+ Misses 10543 10534 -9
Continue to review full report at Codecov.
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
Description
This PR is for a fix in moveit_servo with regards to clearing the stop_request_ flag. There were some situations where after a move was complete and the reset on the flag was called, another thread called stopMotion() again and set the flag back to 1. This prevents any bugginess by assuring that stop_requested_ starts out as false whenever moveToPose is called.
Checklist