Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop_requested_ flag clearing fix #2537

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

parunapu
Copy link
Contributor

@parunapu parunapu commented Mar 4, 2021

Description

This PR is for a fix in moveit_servo with regards to clearing the stop_request_ flag. There were some situations where after a move was complete and the reset on the flag was called, another thread called stopMotion() again and set the flag back to 1. This prevents any bugginess by assuring that stop_requested_ starts out as false whenever moveToPose is called.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Mar 4, 2021

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was involved in testing this, so it looks good to me.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #2537 (2ac8321) into master (30a170f) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2537      +/-   ##
==========================================
+ Coverage   60.20%   60.23%   +0.04%     
==========================================
  Files         351      351              
  Lines       26485    26485              
==========================================
+ Hits        15942    15951       +9     
+ Misses      10543    10534       -9     
Impacted Files Coverage Δ
moveit_ros/moveit_servo/src/pose_tracking.cpp 46.11% <ø> (ø)
...ipulation/pick_place/src/manipulation_pipeline.cpp 73.41% <0.00%> (+1.07%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 84.56% <0.00%> (+1.48%) ⬆️
.../ompl_interface/src/detail/constrained_sampler.cpp 60.00% <0.00%> (+17.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a170f...7932453. Read the comment docs.

@JafarAbdi JafarAbdi merged commit 55b5878 into moveit:master Mar 11, 2021
@welcome
Copy link

welcome bot commented Mar 11, 2021

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@tylerjw tylerjw mentioned this pull request Apr 9, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Apr 29, 2021
@tylerjw tylerjw mentioned this pull request Apr 29, 2021
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request May 3, 2021
tylerjw pushed a commit that referenced this pull request May 3, 2021
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants