Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo: minor fixups #2759

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Servo: minor fixups #2759

merged 1 commit into from
Jul 9, 2021

Conversation

toru-kuga
Copy link
Contributor

@toru-kuga toru-kuga commented Jul 9, 2021

Description

Some fix, that seemed wrong from the code context.
The fix are minor and not serious.
-fixed a wrapper calling wrong member, though normally returning same value
-suppressed a wrong ROS_WARN message

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Jul 9, 2021

Thanks for helping in improving MoveIt and open source robotics!

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2759 (ed91125) into master (83c82e3) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
- Coverage   60.49%   60.43%   -0.06%     
==========================================
  Files         404      404              
  Lines       29670    29670              
==========================================
- Hits        17947    17927      -20     
- Misses      11723    11743      +20     
Impacted Files Coverage Δ
moveit_ros/moveit_servo/src/servo.cpp 68.71% <0.00%> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 63.70% <100.00%> (-0.20%) ⬇️
.../ompl_interface/src/detail/constrained_sampler.cpp 43.25% <0.00%> (-16.21%) ⬇️
...e/src/parameterization/model_based_state_space.cpp 68.31% <0.00%> (-2.81%) ⬇️
moveit_core/robot_model/src/joint_model_group.cpp 63.06% <0.00%> (-1.94%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 81.42% <0.00%> (-1.92%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 78.18% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c82e3...ed91125. Read the comment docs.

@AndyZe AndyZe changed the title Code fix in moveit_servo that looked wrong. Servo: minor fixups Jul 9, 2021
@AndyZe AndyZe merged commit c6c0eb4 into moveit:master Jul 9, 2021
@welcome
Copy link

welcome bot commented Jul 9, 2021

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants