Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing compatibility header for Wily #364

Merged
merged 1 commit into from Nov 16, 2016

Conversation

davetcoleman
Copy link
Member

@davetcoleman davetcoleman commented Nov 16, 2016

Wily was still failing when building tests:

Errors     << moveit_core:make /root/ws_moveit/logs/moveit_core/build.make.001.log
In file included from /root/ws_moveit/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:39:0:
/root/ws_moveit/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.h:170:34: error: ‘**urdf::JointConstSharedPtr**’ has not been declared
   void addJointToChainInfo(urdf::JointConstSharedPtr joint, moveit_msgs::KinematicSolverInfo &info);
                                  ^
/root/ws_moveit/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp: In member function ‘bool pr2_arm_kinematics::PR2ArmIK::init(const urdf::ModelInterface&, const string&, const string&)’:
/root/ws_moveit/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:61:3: error: ‘**LinkConstSharedPtr**’ is not a member of ‘urdf’
   urdf::LinkConstSharedPtr link = robot_model.getLink(tip_name);

Need to include changes in ros/robot_model#160

@davetcoleman davetcoleman mentioned this pull request Nov 16, 2016
19 tasks
@davetcoleman
Copy link
Member Author

Travis passed! This is what is breaking https://travis-ci.org/ros-planning/moveit_ci/jobs/176416385 and I think what is blocking Kinetic

@130s
Copy link
Member

130s commented Nov 16, 2016

Wow, that makes the simplest sense!

@130s 130s merged commit 04cee43 into ros-planning:kinetic-devel Nov 16, 2016
@davetcoleman davetcoleman deleted the kinetic-fix-wily-test branch November 16, 2016 21:34
@davetcoleman davetcoleman restored the kinetic-fix-wily-test branch January 4, 2017 16:45
JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Mar 24, 2022
…lanning#364)

* Fix seg faults in setCollisionDetectorType()
* Add unit test for switching collision detector types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants