Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSA] Upgrade templates to ROS 2 #1101

Merged
merged 3 commits into from
Mar 10, 2022
Merged

[MSA] Upgrade templates to ROS 2 #1101

merged 3 commits into from
Mar 10, 2022

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Mar 7, 2022

Description

Change the templates (and dependency block generating code) to ROS 2 standards.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link

mergify bot commented Mar 7, 2022

Please target the main branch for development, we will backport the changes to feature/msa for you if approved and if they don't break API.

@DLu DLu requested a review from vatanaksoytezer March 7, 2022 16:20
DLu and others added 2 commits March 8, 2022 10:10
@DLu @henningkayser
Apply suggestions from code review
7214375 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
@DLu
XML Scheme Validation
e4605d2
@vatanaksoytezer vatanaksoytezer merged commit a80c353 into moveit:feature/msa Mar 10, 2022
@DLu DLu deleted the msa/feature/ros2 branch March 11, 2022 15:09
DLu added a commit to DLu/moveit2 that referenced this pull request May 19, 2022
@DLu @henningkayser
[MSA] Upgrade templates to ROS 2 (moveit#1101)
2a69b82 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
vatanaksoytezer pushed a commit that referenced this pull request May 25, 2022
@DLu @henningkayser
[MSA] Upgrade templates to ROS 2 (#1101)
34dc382 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
vatanaksoytezer pushed a commit that referenced this pull request May 31, 2022
@DLu @henningkayser
[MSA] Upgrade templates to ROS 2 (#1101)
8413d23 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
vatanaksoytezer pushed a commit that referenced this pull request May 31, 2022
@DLu @henningkayser
[MSA] Upgrade templates to ROS 2 (#1101)
18e54d2 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
@DLu @henningkayser
[MSA] Upgrade templates to ROS 2 (moveit#1101)
8216768 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
@DLu @henningkayser
[MSA] Upgrade templates to ROS 2 (moveit#1101)
5e34567 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
vatanaksoytezer pushed a commit that referenced this pull request Jun 14, 2022
@DLu @henningkayser
[MSA] Upgrade templates to ROS 2 (#1101)
c53935b 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DLu @henningkayser @vatanaksoytezer