Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with MoveIt #1402

Merged
merged 10 commits into from
Jun 29, 2022
Merged

Sync with MoveIt #1402

merged 10 commits into from
Jun 29, 2022

Conversation

Abishalini
Copy link
Contributor

Description

Sync the following commits

* [2022-06-14] [a436a9771] | Fix PlanarJointModel::satisfiesPositionBounds (#3160) {{Rufus Wong}}  (moveit1/noetic-devel, moveit1/master)
*   [2022-06-11] [e364749bf] | Merge pull request #3137 from TAMS-Group/pr-master-monitor-dynamics {{Michael Görner}} 
|\  
| * [2022-06-11] [a2d058c13] | document new move_group parameter {{v4hn}} 
| * [2022-05-16] [37864cf0d] | optionally enable dynamics monitoring in move_group node {{Michael Görner}} 
| * [2022-05-16] [1b0a3a47b] | convert move_group to LOGNAME {{Michael Görner}} 
|/  
* [2022-05-30] [a80dd9d6a] | Add missing headers {{Jochen Sprickerhof}} 
* [2022-05-30] [b17b240d9] | Switch to hpp headers of pluginlib {{Jochen Sprickerhof}} 
* [2022-05-18] [3cbcbadf1] | Adds another test case to #3124 and adds some further minor improvements to the original PR (#3142) {{Robert Haschke}} 
* [2022-05-16] [9202830ef] | Fix bug in applying planning scene diffs that have attached collision objects (#3124) {{Jafar}} 

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

JafarAbdi and others added 9 commits May 16, 2022 10:52
… objects (#3124)

* Add test that trigger the bug in applying scene that have robot state
diffs

* Fix a bug in planning scene diffs where having applying two diffs would cause them to override the aco

* Fix a bug where removing an attached collision object would keep it in the scene

* Update moveit_core/planning_scene/test/test_planning_scene.cpp

Co-authored-by: AndyZe <andyz@utexas.edu>

* Update moveit_core/planning_scene/test/test_planning_scene.cpp

Co-authored-by: AndyZe <andyz@utexas.edu>

* Update moveit_core/planning_scene/src/planning_scene.cpp

Co-authored-by: AndyZe <andyz@utexas.edu>

* Check parent pointer

Co-authored-by: AndyZe <andyz@utexas.edu>
Without this copies of the current robot state will not include velocities/efforts
even when the driver publishes them. Disabling this by default still makes sense
because many use-cases do not need this information at all and copying it in every joint state update
incurs additional load.
default to false because the only upstream feature that can profit
from it is the TrajectoryMonitor that can record the trajectory executed
through the MoveGroup action.
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1402 (503b22f) into main (d531246) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
+ Coverage   61.55%   61.57%   +0.02%     
==========================================
  Files         274      274              
  Lines       24982    24982              
==========================================
+ Hits        15375    15379       +4     
+ Misses       9607     9603       -4     
Impacted Files Coverage Δ
moveit_core/planning_scene/src/planning_scene.cpp 52.53% <ø> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.73% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d531246...503b22f. Read the comment docs.

@tylerjw tylerjw merged commit 504a2c7 into moveit:main Jun 29, 2022
@Abishalini Abishalini deleted the pr-sync-a436a97 branch June 29, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants