-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with MoveIt #1402
Merged
Merged
Sync with MoveIt #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… objects (#3124) * Add test that trigger the bug in applying scene that have robot state diffs * Fix a bug in planning scene diffs where having applying two diffs would cause them to override the aco * Fix a bug where removing an attached collision object would keep it in the scene * Update moveit_core/planning_scene/test/test_planning_scene.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Update moveit_core/planning_scene/test/test_planning_scene.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Update moveit_core/planning_scene/src/planning_scene.cpp Co-authored-by: AndyZe <andyz@utexas.edu> * Check parent pointer Co-authored-by: AndyZe <andyz@utexas.edu>
…nts to the original PR (#3142)
Without this copies of the current robot state will not include velocities/efforts even when the driver publishes them. Disabling this by default still makes sense because many use-cases do not need this information at all and copying it in every joint state update incurs additional load.
default to false because the only upstream feature that can profit from it is the TrajectoryMonitor that can record the trajectory executed through the MoveGroup action.
move_group can optionally monitor dynamics
Codecov Report
@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
+ Coverage 61.55% 61.57% +0.02%
==========================================
Files 274 274
Lines 24982 24982
==========================================
+ Hits 15375 15379 +4
+ Misses 9607 9603 -4
Continue to review full report at Codecov.
|
2ed4571
to
503b22f
Compare
tylerjw
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sync the following commits
Checklist