Fix clang-tidy issues

[rhaschke]

Having the clang-tidy check performance-unnecessary-value-param disabled for a few years, lead to the introduction of several shortcomings in the code, which should be fixed asap.
Applying all automatic fixes from clang-tidy is not a good idea as you can see from second commit, trying to cleanup a few of them. Somebody from the MoveIt2 team should take over and clean up the remaining ones. @henningkayser, can you please coordinate this work?

[henningkayser]

I think I got most of them. I'm still seeing some "candidate function not viable: no known conversion ..." errors locally, will look into it tomorrow.

[codecov]

Codecov Report

Base: 50.97% // Head: 50.98% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (89c9a43) compared to base (a2aa1a6).
Patch coverage: 47.62% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1706      +/-   ##
==========================================
+ Coverage   50.97%   50.98%   +0.01%     
==========================================
  Files         378      378              
  Lines       31649    31657       +8     
==========================================
+ Hits        16131    16137       +6     
- Misses      15518    15520       +2     

Impacted Files	Coverage Δ
...e/include/moveit/kinematics_base/kinematics_base.h	76.32% <ø> (ø)
...nclude/moveit/robot_state/cartesian_interpolator.h	50.00% <0.00%> (ø)
...bot_state/include/moveit/robot_state/robot_state.h	90.14% <ø> (ø)
...it_core/robot_state/src/cartesian_interpolator.cpp	39.14% <ø> (ø)
moveit_core/robot_state/src/robot_state.cpp	47.91% <ø> (ø)
...veit/ompl_interface/model_based_planning_context.h	84.45% <ø> (ø)
...oveit_servo/include/moveit_servo/collision_check.h	100.00% <ø> (ø)
...lude/moveit_servo/parameter_descriptor_builder.hpp	100.00% <ø> (ø)
.../moveit_servo/include/moveit_servo/pose_tracking.h	100.00% <ø> (ø)
...ros/moveit_servo/include/moveit_servo/servo_node.h	100.00% <ø> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mergify]

This pull request is in conflict. Could you fix it @rhaschke?

[henningkayser]

With the last commit, clang-tidy succeeds for me locally

[rhaschke]

Thanks for handling this, Hennig. There are a few clang warnings left though (which cannot be resolved automatically).

[henningkayser]

Thanks for handling this, Hennig. There are a few clang warnings left though (which cannot be resolved automatically).

What warnings are you talking about? CI is happy and locally I don't see related warnings or errors anymore either?

[AndyZe]

I don't see any warnings locally, either.

[rhaschke]

CI doesn't use -Werror when building with clang. Thus, CI reports success. But if you open the build_target_workspace section, you will see a few warnings. Most of them are related to gmock, which will be fixed via ament/googletest#21 and ament/ament_cmake#408. However, there a few others as well. Maybe you should use -Werror for the clang build as well (if the gmock issues are resolved upstream).

[rhaschke]

I approve as well. The warnings can be tackled later as well. This PR should be merged soon to unblock other PRs (which currently will fail due to clang-tidy issues).