Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix moveit_core dependency on tf2_kdl #1817

Merged
merged 2 commits into from Dec 20, 2022
Merged

Fix moveit_core dependency on tf2_kdl #1817

merged 2 commits into from Dec 20, 2022

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Dec 20, 2022

Description

This is a proper dependency, and not only a test dependency. It is still needed when building moveit_core with -DBUILD_TESTING=OFF.

The dependency is unconditionally referenced here:
https://github.com/ros-planning/moveit2/blob/fca8e9bd3f41e6bff5aadbf75c494b5cc3fa25ee/moveit_core/CMakeLists.txt#L50

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@cottsay
Fix moveit_core dependency on tf2_kdl
58f4929 
This is a proper dependency, and not only a test dependency. It is still
needed when building moveit_core with -DBUILD_TESTING=OFF.
henningkayser
henningkayser approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@henningkayser henningkayser added the backport-humble Mergify label that triggers a PR backport to Humble label Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022 •
edited

Codecov Report

Base: 50.29% // Head: 50.26% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (b67bd67) compared to base (fca8e9b).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
- Coverage   50.29%   50.26%   -0.02%     
==========================================
  Files         374      374              
  Lines       31286    31286              
==========================================
- Hits        15733    15724       -9     
- Misses      15553    15562       +9
Impacted Files Coverage Δ
moveit_ros/moveit_servo/src/servo_calcs.cpp 65.97% <0.00%> (-1.45%) ⬇️
moveit_ros/moveit_servo/src/pose_tracking.cpp 77.11% <0.00%> (-0.46%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.95% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henningkayser henningkayser merged commit 9f7d6df into moveit:main Dec 20, 2022
@mergify mergify bot mentioned this pull request Dec 20, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 20, 2022
@cottsay @mergify
Fix moveit_core dependency on tf2_kdl (#1817)
c318a9c 
This is a proper dependency, and not only a test dependency. It is still
needed when building moveit_core with -DBUILD_TESTING=OFF.

(cherry picked from commit 9f7d6df)
@cottsay cottsay deleted the tf2_kdl_dep branch December 20, 2022 19:07
sjahr pushed a commit that referenced this pull request Dec 20, 2022
@mergify @cottsay
Fix moveit_core dependency on tf2_kdl (#1817) (#1823)
fa640f8 
This is a proper dependency, and not only a test dependency. It is still
needed when building moveit_core with -DBUILD_TESTING=OFF.

(cherry picked from commit 9f7d6df)

Co-authored-by: Scott K Logan <logans@cottsay.net>
@movefasta movefasta mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

@JafarAbdi JafarAbdi JafarAbdi approved these changes

Assignees
No one assigned
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cottsay @henningkayser @vatanaksoytezer @JafarAbdi