Add new sub-module to moveit_core, logging #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate logging within moveit_core by creating a dedicated submodule that integrates prior ROS macros
| /* Author: Víctor Mayoral Vilches */ | ||
|
|
||
| #ifndef MOVEIT_LOGGING_ | ||
| #define MOVEIT_LOGGING_ |
There was a problem hiding this comment.
Suggested change
| #define MOVEIT_LOGGING_ | |
| #define MOVEIT_MACROS_LOGGING_ |
|
|
||
| /* Author: Víctor Mayoral Vilches */ | ||
|
|
||
| #ifndef MOVEIT_LOGGING_ |
There was a problem hiding this comment.
Suggested change
| #ifndef MOVEIT_LOGGING_ | |
| #ifndef MOVEIT_MACROS_LOGGING_ |
mlautman
approved these changes
Feb 19, 2019
|
@vmayoral I approved and merged before I saw @davetcoleman's feedback. Please apply those changes in a new PR |
henningkayser
pushed a commit
that referenced
this pull request
Aug 28, 2020
backport fixes, some cleanup clang format fixes more cleanup + clang format #2
henningkayser
pushed a commit
that referenced
this pull request
Aug 28, 2020
clang format fixes #2 cmake style fixes, clang warning fixes revert clang warning fixes rebase fixes
henningkayser
added a commit
that referenced
this pull request
Aug 28, 2020
AndyZe
referenced
this pull request
in AndyZe/moveit2
Sep 6, 2020
backport fixes, some cleanup clang format fixes more cleanup + clang format #2
AndyZe
referenced
this pull request
in AndyZe/moveit2
Sep 6, 2020
clang format fixes #2 cmake style fixes, clang warning fixes revert clang warning fixes rebase fixes
AndyZe
referenced
this pull request
in AndyZe/moveit2
Sep 6, 2020
galou
pushed a commit
to galou/moveit2
that referenced
this pull request
Mar 4, 2022
Km devel galactic changes, included: added separate private node and it's SingleThreadedExecutor to perfor… 3910e52 Get parameter trajectory_execution.execution_duration_monitoring in… b533006 Use emulated time in action-based controller [GE, JD] d1755a7 Use a steady clock for timeout for IK [GE] 7311f41
MikeWrock
referenced
this pull request
in MikeWrock/moveit2
Aug 15, 2022
* updated images with Panda * removing old PR2 images * updating setup assistant tutorial
shashwat-aivot
referenced
this pull request
in AivotRobotics/moveit2
Mar 19, 2023
Closed
This was referenced Jul 3, 2023
sjahr
added a commit
that referenced
this pull request
Dec 6, 2023
* Enable chaining multiple planners
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.