Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port warehouse part of moveit benchmarks to ROS2 #301

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

RoboticsYY
Copy link
Contributor

@RoboticsYY RoboticsYY commented Oct 28, 2020

Description

This PR intends to make moveit_ros_benchmarks work with warehouse on ROS2.

  • Run benchmarks without warehouse
ros2 launch moveit_ros_benchmarks demo_panda_predefined_poses.launch.py
  • Run benchmarks with warehouse
    • Bring up motion planning rviz plugin
      ros2 launch run_move_group run_move_group.launch.py
    • Follow the methods in benchmark tutorial to save the planning scene and robot states
    • Run benchmark program
      ros2 launch moveit_ros_benchmarks demo_panda.launch.py
  • The output will be a KitchenPick1*.log file in /tmp//tmp/moveit_benchmarks
  • Visualize the output:
ros2 run moveit_ros_benchmarks moveit_benchmark_statistics.py -p <name of pdf file> <path of log file>

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #301 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   47.64%   47.64%           
=======================================
  Files         154      154           
  Lines       14844    14844           
=======================================
  Hits         7073     7073           
  Misses       7771     7771           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dba4db...bd9f362. Read the comment docs.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoboticsYY flawless imo, what is still WIP in your opinion?

@RoboticsYY
Copy link
Contributor Author

@RoboticsYY flawless imo, what is still WIP in your opinion?

I haven't ported the launch files and tested them. But I think there will be no big problem, because the warehouse part doesn't involve much of ROS.

@RoboticsYY RoboticsYY changed the title [WIP] Port warehouse part of moveit benchmarks to ROS2 Port warehouse part of moveit benchmarks to ROS2 Nov 4, 2020
@henningkayser henningkayser merged commit a810037 into moveit:main Nov 4, 2020
@RoboticsYY RoboticsYY deleted the pr-moveit_benchmark_warehouse branch November 11, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants