Add braces around blocks.

[corycrean]

• Add braces around blocks.
• Add a check for braces to clang-tidy.

Description

This PR addresses #854.

Checklist

• Required by CI: Code is auto formatted using clang-format
• Extend the tutorials / documentation reference
• Document API changes relevant to the user in the MIGRATION.md notes
• Create tests, which fail without this PR reference
• Include a screenshot if changing a GUI
• While waiting for someone to review your request, please help review another open pull request to support the maintainers

[codecov]

Codecov Report

Base: 50.94% // Head: 50.94% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e581b21) compared to base (6e0fce3).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
- Coverage   50.94%   50.94%   -0.00%     
==========================================
  Files         378      378              
  Lines       31658    31659       +1     
==========================================
  Hits        16126    16126              
- Misses      15532    15533       +1     

Impacted Files	Coverage Δ
...lude/moveit/collision_detection/collision_common.h	83.88% <ø> (ø)
.../collision_detection/test_collision_common_panda.h	98.73% <ø> (ø)
...on/include/moveit/collision_detection/world_diff.h	44.45% <ø> (ø)
...eit_core/collision_detection/src/collision_env.cpp	72.58% <ø> (ø)
..._core/collision_detection/src/collision_matrix.cpp	37.15% <ø> (ø)
...llision_detection/src/collision_octomap_filter.cpp	0.00% <ø> (ø)
...t_core/collision_detection/src/collision_tools.cpp	0.00% <ø> (ø)
moveit_core/collision_detection/src/world.cpp	88.11% <ø> (ø)
moveit_core/collision_detection/src/world_diff.cpp	85.19% <ø> (ø)
...ion_bullet/src/bullet_integration/bullet_utils.cpp	64.77% <ø> (ø)
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mergify]

This pull request is in conflict. Could you fix it @corycrean?

[henningkayser]

Great readibility improvement! I think in theory there is nothing that could really go wrong, but this is really a lot to review

[jliukkonen]

Looks good to me.

[mergify]

This pull request is in conflict. Could you fix it @corycrean?

[mergify]

This pull request is in conflict. Could you fix it @corycrean?

[tylerjw]

Wow, this is a huge change. Thank you for doing this work. I'm happy to merge this if you don't mind rebasing so it can be applied.

[tylerjw]

@corycrean I'm sorry this got so out of date and has so many conflicts. Do you think you could rebase this and make it so it could be merged?

[tylerjw]

If you run pre-commit does the formatting of this get fixed?

[corycrean]

Unfortunately no. But I just fixed this manually.

[ChrisThrasher]

Looks like a formatting issue got through in this PR

[ChrisThrasher]

I wanted to point out how the argument that drove the creation of #854 only applies to codebases without autoformatters. Misleading indentation is a real problem but it's not a problem MoveIt has so there was no need to add this check to address that. We already have no misleading indentation.