-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower minimum cmake version #817
Lower minimum cmake version #817
Conversation
Can't really make heads or tails of the ros_gazebo_pkgs-ci-pr_any_melodic-bionic-amd64 CI build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me, everything in the repo builds fine, and if anyone building on top needs a higher version it's up to them to bump it.
The ROS1 builds on build.osrfoundation.org are broken right now, so don't worry about it.
patch-ab: adapt patch-ad: python 3 compatibility Changelog for package gazebo_ros ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2.8.6 (2019-12-26) ------------------ * ROS API: remove unhelpful error in GetWorldProperties call (`%747 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/747>`_) * Create reconfigure thread only if network enabled (`%919 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/919>`_) This thread was blocked in client.waitForExistance because the services it depends on are only created if `enable_ros_network` is true. This in turn blocked gazebo from being shut down. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * spawn_model: Fix urlparse imports for Python 3 * spawn_model: Ensure that "model_xml" is a string, required for Python 3 * catkin_find gazebo plugin from bin folder. (`%993 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/993>`_) * [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_) * Fix CMake install error for Windows build. * conditionally include <sys/time.h> * provide Windows implemenation for setenv. (`%879 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/879>`_) * implement basic gazebo scripts to support launch file on Windows build. (`%880 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/880>`_) * Contributors: Kartik Mohta, Kevin Allen, Sean Yen, Shane Loretz 2.8.5 (2019-06-04) ------------------ * Add output arg to launch files, plus some small fixes (melodic) (`%907 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/907>`_) * Add output arg to empty_world * add output arg to elevator_world * add output arg to range_world * don't set use_sim_time in range_world Instead parse it to empty world, where it will be set. * add xml prolog to all launch files * Remove unnecessary arg in range_world.launch * use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_) * fix issue `%198 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/198>`_ (`%825 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/825>`_) * Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_) * Contributors: Matthijs van der Burgh, Paul Bovbel, Sean Yen [MSFT], Steven Peters Changelog for package gazebo_ros_control ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2.8.6 (2019-12-26) ------------------ * restrict Windows header namespace. (`%1023 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/1023>`_) * [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_) * Fix CMake install error for Windows build. * conditionally include <sys/time.h> * Contributors: Sean Yen 2.8.5 (2019-06-04) ------------------ * use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_) * Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_) * Contributors: Paul Bovbel, Sean Yen [MSFT] Changelog for package gazebo_plugins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2.8.6 (2019-12-26) ------------------ * gazebo_plugins: export plugin path in package.xml (`%923 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/923>`_) * Fix destructor of gazebo_ros_diff_drive.cpp (`%1021 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/1021>`_) Fix issue referenced in `%123 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/123>`_ where the destructor of ROS DiffDrive plugin causes gzserver to crash on model deletion. * [Windows][melodic-devel] more Windows build break fix (`%975 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/975>`_) * Fix CMake install error for Windows build. * conditionally include <sys/time.h> * Use ignition::math::Rand utility for portability. (`%878 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/878>`_) * Contributors: Ben Wolsieffer, RemiRigal, Sean Yen 2.8.5 (2019-06-04) ------------------ * use C++11 std sleep instead of usleep. (`%877 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/877>`_) * Lower minimum cmake version (`%817 <https://github.com/ros-simulation/gazebo_ros_pkgs/issues/817>`_) * Contributors: Paul Bovbel, Sean Yen [MSFT]
This patch lowers the required cmake version so that package builds on xenial. We've been running this build for some time with no adverse effects.