Complete the full set of *Ptr typedefs

[bmagyar]

Naively committing to std::shared_ptr-s didn't work in realtime_tools but it revealed that the set of typedefs in the macro are not complete. This should ease migrating from boost::shared_ptr for all users of actionlib using typedefs.

[bmagyar]

@mikaelarguedas should I retarget it against indigo-devel?

[clalancette]

@mikaelarguedas Are you comfortable with merging this for Melodic? If so, a commit and release should help us get ros_controllers building again.

[mikaelarguedas]

should I retarget it against indigo-devel?

Yes I'm currently still using indigo-devel for all distros as the API/ABI breaking changes didnt make it to melodic. I retargeted the PR

[mikaelarguedas]

Thanks @bmagyar for the patch!

[bmagyar]

Thanks for merging!

…

On Mon, 21 May 2018, 19:59 Mikael Arguedas, ***@***.***> wrote: Thanks @bmagyar <https://github.com/bmagyar> for the patch! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#106 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADXH4WvFiqFna_-kmlCy0SD9ZMev95YDks5t0w6KgaJpZM4TykTT> .

[mikaelarguedas]

@bmagyar FYI: I don't think I'll get around releasing this before the Melodic release date (Wednesday). So I will likely release that after the release is announced, at which point you should be able to push your new version of ros_controllers.

[bmagyar]

That's perfectly fine, thanks!

…

On Mon, 21 May 2018, 22:45 Mikael Arguedas, ***@***.***> wrote: @bmagyar <https://github.com/bmagyar> FYI: I don't think I'll get around releasing this before the Melodic release date (Wednesday). So I will likely release that after the release is announced, at which point you should be able to push your new version of ros_controllers. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#106 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADXH4R5P44Mkbi-DaoPEfleUx77gn84wks5t0zVygaJpZM4TykTT> .

[clalancette]

@bmagyar This ended up causing problems when used in combination with realtime_tools. Ultimately I think the fix is to remove the typedefs from realtime_tools, but for now I'm going to go back to earlier versions for both for the Melodic release: ros/rosdistro#17934 and ros/rosdistro#17935

[bmagyar]

Now that the first Melodic release is officially out, could we try to get back to this?

One note is that the actionlib changes on indigo-devel will only for on Melodic without explicitly enabling C++11. That's why I wasn't sure if it should be targeted to melodic-devel or indigo-devel. Having only actionlib merged will then break the currently released version of realtime_tools which carries some typedefs that were added to actionlib so the ideal solution is to push the changes of those at the same time.