-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to get a list of running action servers #44
Comments
I would also like to have a tool like this, to easily check if an action server is set up correctly. |
+1 |
@130s I think that creating a CLT for this single verb is a bit too much as well. A python script installed by the package that can be rosrun'd would do the job I think (e.g.
@luator I'm not sure this will save you a lot of time to run @keerthanamanivannan, @ruffsl Could you describe what you'd like such a tool to do? a strict equivalent of Thanks! |
Here would be my supposed wishlist for
|
@mikaelarguedas To be honest, I wasn't aware that I could simply check for the topics (when thinking about it, it totally makes sense, though). However, only because the topic is listed by Anyway, I think a tool as proposed by ruffsl could be useful. |
I also had in mind something like what @ruffsl proposed. |
In the line of this discussion, have a look at axcli. |
Interesting, the [tab|tab] listing uses rostopic list and just scrapes for uses of |
Just came across mcgill-robotics/rosaction:
|
Thanks for the interesting finding for some existing repos. I've asked if maintainers of each repo gets interested in sending pull requests to the upstream somewhere appropriate so that the rest of us in rosland can use without adding extra dependency: |
A bit of a +1 post. Just want to note that the fact that no good CLI like |
Hey, I managed to compile stuff from other projects into a CLI tool. Now I want to add bash completion. This should not be hard, it's pretty similar to rosservice and much of completion code can be reused. My question is: what is the best way to add it? Thing is that existing completions live in rosbash package and provide completions for ROS core CLI tools while actionlib is kind of add-on package. It would be nice if rosbash provided some plugin API to allow other packages to provide more completions. What do you think? |
Nevermind guys, I figured out how to provide completions for new tool. Just need to make it pass CI. |
@maximkulkin wrote:
+1 for doing this, but looking at the files in #115, I don't see any licenses or mentions of the (authors of the) projects you used. Would that be something you still need to add? |
Author here of mcgill-robotics/rosaction, which seems to be the basis of #115. I don't know much about licensing, but I'm open to relicensing or whatnot if that helps get this in. Also, wouldn't the autocompletion need to support |
Well, I used above mentioned projects as an examples and source code is not copyrighted although am OK to put whatever mention you feel necessary. |
As of autocompletion: I do not use those other shells, so I can not test it there. I'll leave it to people who use those shells. |
@maximkulkin wrote:
I don't believe it works that way :) Software is always copyrighted. It is the license attached that allows you to use it, or not. In this case the following licenses were attached to the source code of the two above mentioned projects:
So both of those projects expressly permit you to use the source code, *provided that you leave any copyright notices in tact, and that you acknowledge the work and authorship of the developers that contributed to those projects. See also the handy summary that Github displays above the Regardless of whether you used any of the code directly, it would probably be fair to mention at least the names of the authors of those other projects. |
I disagree: I used sources of those projects to figure out how to do basic things and then implemented that stuff myself, adding error handling and tests. It's like you use tutorials or examples to know how to do things. There were no tricky algorithms involved, just obvious stuff that could be found elsewhere. The MIT license says that copyright should be preserved in "all copies or substantial portions", but those are neither this or that. |
I'll leave it to you to do what you feel is the right thing to do. I just wanted to correct you when you wrote "source code is not copyrighted". Edit:
This is called "conceptual reuse" and is actually something that is considered by some people to also be covered by licenses: without looking at those sources it would have possibly taken you more time to figure out how to things. By allowing you to look at the sources of those other projects, the authors potentially saved you valueable time. That in itself might be enough to list those projects as inspiration or precursors. |
Well, the license does not mention anything on "conceptual reuse". I actually don't care who will be listed where (and I do not list myself anywhere), but I do not see this practice used in ROS projects, so I do not know where to put this stuff. And it looks like original author don't mind (@anassinator are you?). |
I don't have any strong opinions about this TBH. I would expect this repo's owners might have something in mind anyways. BTW, it seems like this repo already has a few precedents like here: https://github.com/ros/actionlib/blob/indigo-devel/src/actionlib/action_server.py#L29-L30 |
Hey I've added a reference to original rosaction repository and my last CI run completed successfully. Take a look. |
Asked here. While the proposed way that uses
rostopic list
(thus is a bit of a hack) seems to work perfectly, I like to have a feature to do that. I wouldn't mind opening a PR but just wonder:rosaction
with alist
verb may sound too much, since there may not be many other things to do withrosaction
command.The text was updated successfully, but these errors were encountered: