Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install includes to include/${project_name} and use more modern CMake #191

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Install includes to include/${project_name} and use more modern CMake #191

merged 1 commit into from
Jan 13, 2022

Conversation

sloretz
Copy link

@sloretz sloretz commented Jan 5, 2022

Part of ros2/ros2#1150

This installs includes to include/${PROJECT_NAME} to mitigate include directory search order issues when overriding packages in desktop.

Part of ament/ament_cmake#365

This removes ament_export_libraries and ament_export_include_directories as they're redundant with the exported CMake targets.

Part of ament/ament_cmake#292

This replaces an ament_target_dependencies() call with target_link_libraries().

@sloretz
Install includes to include/
2bd80b7 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Jan 5, 2022
@sloretz sloretz mentioned this pull request Jan 5, 2022
Merged
@sloretz sloretz marked this pull request as ready for review January 11, 2022 19:06
@sloretz
Copy link
Author

sloretz commented Jan 13, 2022

CI (repos file build: --packages-above-and-dependencies class_loader test: --packages-select class_loader)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@sloretz
Copy link
Author

sloretz commented Jan 13, 2022

All of the test failures are due to cpplint include order, otherwise CI LGTM.

@jacobperron
Copy link

cpplint errors are addressed on ros2, so I think we can merge this PR.

@gbiggs gbiggs merged commit 0e9a1de into ros2 Jan 13, 2022
@gbiggs gbiggs deleted the sloretz__easy_idso_part1 branch January 13, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@gbiggs gbiggs gbiggs approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloretz @jacobperron @gbiggs