Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shebang line for python3 #141

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

mikaelarguedas
Copy link
Member

Similar to ros-visualization/rqt_graph#43

Without this change the script cannot be rosrun on Noetic/Focal and results in:
/usr/bin/env: ‘python’: No such file or directory

Python scripts need to be installed using catkin_install_python for the shebang line to be rewritten to point to python3. More details at https://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs

@Karsten1987 @sloretz FYI

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
Copy link
Member Author

@Karsten1987 @sloretz friendly 🛎️ Is there anything that I can do to help getting this merged/released in noetic?

@Karsten1987
Copy link
Contributor

the ROS1 branches are pretty much unmaintained and I guess the repo should be flagged as such. Maybe it's a good idea to transfer the ownership to the orphaned package maintainers?

I am pretty happy to review any changes needed for ROS2, but restrain myself from maintaining the ROS1 branches.

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
Copy link
Member Author

the ROS1 branches are pretty much unmaintained and I guess the repo should be flagged as such. Maybe it's a good idea to transfer the ownership to the orphaned package maintainers?

It seems like a sensible thing to do

I am pretty happy to review any changes needed for ROS2, but restrain myself from maintaining the ROS1 branches.

That's understandable. I fully appreciate the effort of porting to Python3 and making an initial release in Noetic 🙇‍♂️ . However the fact that the initial release is broken to the point that not a single node of this package can be used undermines that porting effort.
That's why I'm kindly tagging the people who performed the initial Python3 port and release to do a one-time follow-up release permitting users to use the package. Happy to help make that happen if there's more I can do than provide Python3 support patches.

@g-gemignani
Copy link
Collaborator

We use this library at Magazino GmbH and we need to port it to python 3 in the near future given Noetic. I imagine us being able to take over the library and maintaining it if no one else is interested in doing so...

@mikaelarguedas
Copy link
Member Author

Thanks @g-gemignani for taking over!
Just saw ros/rosdistro#26156, do you think this PR can make it into a release soon ?

Copy link
Collaborator

@g-gemignani g-gemignani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@g-gemignani g-gemignani merged commit c41607f into ros:noetic-devel Aug 14, 2020
@g-gemignani
Copy link
Collaborator

Thanks @g-gemignani for taking over!
Just saw ros/rosdistro#26156, do you think this PR can make it into a release soon ?

I am happy to help out. The reason why this commit is not in ros/rosdistro#26156 is because first I wanted to get the process under control. These days I will go through the different PRs and see if I can make another release in the next few days :)

@mikaelarguedas
Copy link
Member Author

that's awesome thanks!

@mikaelarguedas mikaelarguedas deleted the fix_python3_shebang branch August 14, 2020 09:55
g-gemignani pushed a commit that referenced this pull request Aug 18, 2020
* fix shebang line for python3

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* fix syntax error

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants