Make getParam() functions of FilterBase const #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The proposed solution does one unnecessary copy of the XmlRpcValue for each bool/int/double just to remove the constness. It might be overcome by const_cast, but I'd strongly vote against that. |
tfoote
approved these changes
Sep 23, 2020
Merged
|
Now that the noetic PR is merged, could this be merged to lunar-devel? |
peci1
added a commit
to peci1/robot_body_filter
that referenced
this pull request
Jan 6, 2022
Allowed by ros/filters#35 (released in Melodic filters 1.8.2 (October 2021) and Noetic filters 1.9.1 (September 2021)).
peci1
added a commit
to ctu-vras/ros-utils
that referenced
this pull request
Aug 26, 2022
Allowed by ros/filters#35 (released in Melodic filters 1.8.2 (October 2021) and Noetic filters 1.9.1 (September 2021)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason for them to be non-const.