Use setuptools instead of distutils #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, ros/catkin#1048 needs to be released to ROS Noetic for this PR to pass. Working on it. |
|
@ros-pull-request-builder retest this please |
|
I am wondering if adding an explicit dependency on |
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
force-pushed
the
sloretz/setuptools
branch
from
e7229ba
to
1aa4fa6
Compare
Explicit dependency in 1aa4fa6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian Buster and Ubuntu Focal distutils has been split to a separate package. With ros/catkin#1048 catkin will prefer to use
setuptoolsinstead ofdistutils. Catkin exports a buildtool depend for python3-setuptools, but it does not do the same for Python 2. Since this PR is targeting thekinetic-develbranch, it both switches tosetuptoolsto match catkin's preference and adds a<buildtool_depend>onpython-setuptoolsso it still works whenROS_PYTHON_VERSIONis 2.