Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #134 changes to message.py #139

Merged
merged 1 commit into from
May 1, 2021
Merged

Revert #134 changes to message.py #139

merged 1 commit into from
May 1, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Apr 30, 2021

This reverts the changes to message.py from #134. This PR makes the codec always be registered so that messages generated with genpy 0.6.14 continue to work when used with Python 2 and newer genpy versions.

Closes #138

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@sloretz sloretz added the bug label Apr 30, 2021
@sloretz sloretz self-assigned this Apr 30, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Apr 30, 2021

@silentpony @apojomovsky @jaejyn @YiHerngOng @eggerk if any of you have an environment where the deserialization error still occurs, would you mind trying this change and reporting if it fixes it for you?

@eggerk
Copy link

eggerk commented Apr 30, 2021

Thank you for the quick fix!

I can confirm that this resolves the issue in my case.

@rovbo-maksim
Copy link

It fixes the problem for me, too.

@sloretz
Copy link
Contributor Author

sloretz commented May 1, 2021

Thanks for the feedback! I tested locally by building custom messages with genpy 0.6.14 and running with 0.6.15 and this version. With 0.6.15 rostopic pub/rostopic echo the subscriber side silently fails and never prints any messages, while with this version it succeeds as expected. I'll merge an make a release into ROS Melodic.

@sloretz sloretz merged commit 8d72296 into main May 1, 2021
@sloretz sloretz deleted the partial_134_revert branch May 1, 2021 16:43
@kvnptl
Copy link

kvnptl commented May 18, 2021

Package version 0.6.16 solves the issue (for Error message: LookupError: unknown error handler name 'rosmsg') for python2. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeserializationError cannot deserialize: unknown error handler name 'rosmsg'
4 participants