Do not subscribe /clock from nodelet load
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ros-pull-request-builder retest this please |
|
Hmm, maybe that was too fast and we actually need to wait for ros_comm release? |
|
The tests in this PR have passed after the required changes in ros_comm have been merged. This is now ready for review. |
|
@sloretz it would be great to have this PR in the larger ros_comm test you called for. Could you please have a look at it? |
sloretz
approved these changes
Sep 20, 2024
mjcarroll
approved these changes
Sep 25, 2024
|
Thanks! Do you intend to make a release of nodelet_core in the period when ros_comm 1.17 is being tested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ros/ros_comm#2342 .
See discussion in https://robotics.stackexchange.com/questions/96165/nodelet-load-process-does-message-deserialization .
When running in
nodelet loadmode, the node doesn't really do anything that would require sim time. It should only run the bond, one service call and nothing else. This PR makes sure that it is the case even if/use_sim_timeis set to true.