cmake 3.5 compatibility #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
sloretz
approved these changes
Aug 27, 2020
|
CI (repos build:
|
sloretz
pushed a commit
that referenced
this pull request
Aug 27, 2020
Signed-off-by: Karsten Knese <karsten@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Dec 7, 2021
* [ROS 2] Add function for same-package pluginlib tests (#201) * Add function for same-package pluginlib tests Adds pluginlib_enable_plugin_testing() This CMake function handles creating a fake install environment for testing pluginlib plugins in the same package that built them. This replaces manually creating this folder structure just to run unit tests. Signed-off-by: Shane Loretz<sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Grammar and unused variable Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Typo in comment Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * cmake 3.5 compatibility (#203) Signed-off-by: Karsten Knese <karsten@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove unused variable output_library (#211) Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses comment here where
POP_FRONTintroduces a dependency to cmake 3.15. This is not available on ubuntu 18.04 which would make it tricky to compile Foxy or ros2 from source.cmake's
REMOVE_ATshould actually do the same thing.