[Foxy] backport pluginlib enable plugin testing #202
Merged
+237
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add function for same-package pluginlib tests Adds pluginlib_enable_plugin_testing() This CMake function handles creating a fake install environment for testing pluginlib plugins in the same package that built them. This replaces manually creating this folder structure just to run unit tests. Signed-off-by: Shane Loretz<sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Grammar and unused variable Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Typo in comment Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
|
Should cherry-pick #203 before backporting |
Signed-off-by: Karsten Knese <karsten@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
Cherry-picked 8b5a1a2 - ready for review again. |
hidmic
reviewed
Oct 19, 2020
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
Cherry-picked #211 onto this branch too |
|
Friendly ping. What's the status of this PR? |
|
I definitely forgot about it. It looks like feedback has been addressed, so it needs a review and CI |
|
CI (Foxy repos, build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-pick backports #201 to ROS Foxy