Skip to content

Conversation

asobhy-qnx
Copy link
Contributor

Fixes #204

Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and should only impact QNX.

@mjcarroll mjcarroll merged commit 9c5b437 into ros:ros2 Sep 3, 2020
@mjcarroll
Copy link
Member

@asobhy-qnx It looks like you are targeting Dashing, would you like for this to be backported to that release?

@asobhy-qnx
Copy link
Contributor Author

@mjcarroll yes please.

mjcarroll added a commit that referenced this pull request Sep 3, 2020
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll added a commit that referenced this pull request Sep 4, 2020
* adds QNX c++ fs library compiler option (#205)
* Also update pluginlib-extras.cmake for QNX

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Ahmed Sobhy <68698147+asobhy-qnx@users.noreply.github.com>
mjcarroll pushed a commit that referenced this pull request Nov 10, 2020
Co-authored-by: Ahmed Sobhy <68698147+asobhy-qnx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants