fix topic_tools environment hook #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this commit, `source /opt/ros/$ROS_DISTRO/setup.bash` fails under the following conditions:
1. topic_tools is installed
2. rosbash is not installed
3. the bash shell has the following options set (which is the default in GitLab CI):
set -o errexit
set -o pipefail
What happens is that since rosbash is not installed, `$(complete | grep -w rosrun)` finds no match, and grep exits with status 1. Since `pipefail` is enabled, this error code is propagated to the return value of the pipe. Since `errexit` is enabled, the script exits immediately.
This commit catches grep exit status 1 (= "no match") and passes everything else through.
|
I've verified that the bug exists in melodic + kinetic, and that this PR fixes it: https://gitlab.com/mintar/ros_comm/-/jobs/89166959 https://gitlab.com/mintar/ros_comm/blob/ci/.gitlab-ci.yml This PR should also be backported to kinetic and lunar. |
|
BTW: I had a hell of a time figuring out what the problem exactly was and why I could reproduce it in GitLab CI, but not locally, before I thought of the shell options. Now I can reproduce it reliably both in GitLab CI and locally. |
|
Thank you for the patch. |
|
@dirk-thomas Thanks for merging! Could you please also backport this patch to kinetic + lunar? |
|
👍 After it has been released into Melodic it will be consider for backporting. |
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 3, 2020
Without this commit, `source /opt/ros/$ROS_DISTRO/setup.bash` fails under the following conditions:
1. topic_tools is installed
2. rosbash is not installed
3. the bash shell has the following options set (which is the default in GitLab CI):
set -o errexit
set -o pipefail
What happens is that since rosbash is not installed, `$(complete | grep -w rosrun)` finds no match, and grep exits with status 1. Since `pipefail` is enabled, this error code is propagated to the return value of the pipe. Since `errexit` is enabled, the script exits immediately.
This commit catches grep exit status 1 (= "no match") and passes everything else through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this commit,
source /opt/ros/$ROS_DISTRO/setup.bashfails under the following conditions:topic_tools is installed
rosbash is not installed
the bash shell has the following options set (which is the default in GitLab CI):
set -o errexit
set -o pipefail
What happens is that since rosbash is not installed,
$(complete | grep -w rosrun)finds no match, and grep exits with status 1. Sincepipefailis enabled, this error code is propagated to the return value of the pipe. Sinceerrexitis enabled, the script exits immediately.This commit catches grep exit status 1 (= "no match") and passes everything else through.
Supersedes #1484.