Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #2128 "TypeError: not enough arguments for format string" #2127

Merged
merged 4 commits into from
Feb 11, 2021
Merged

fix bug #2128 "TypeError: not enough arguments for format string" #2127

merged 4 commits into from
Feb 11, 2021

Conversation

jinmenglei
Copy link
Contributor

@jinmenglei jinmenglei commented Feb 6, 2021

fix bug #2128 "TypeError: not enough arguments for format string" in DeserializationErroralizationError

@jinmenglei jinmenglei changed the title fix bug "TypeError: not enough arguments for format string" fix bug #2128 "TypeError: not enough arguments for format string" Feb 7, 2021
@jinmenglei jinmenglei marked this pull request as draft February 7, 2021 02:11
@jinmenglei jinmenglei marked this pull request as ready for review February 7, 2021 02:12
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

clients/rospy/src/rospy/impl/tcpros_base.py Outdated Show resolved Hide resolved
I take advice

Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
229143434@qq.com added 2 commits February 8, 2021 10:57
@jinmenglei
Copy link
Contributor Author

@fujitatomoya How long will it take to merge? I want to apply for another pr

@fujitatomoya
Copy link
Contributor

@jinmenglei i am not sure about that, since i am not a maintainer.

CC: @sloretz @jacobperron friendly ping.

@jinmenglei
Copy link
Contributor Author

@fujitatomoya thank you

Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jacobperron jacobperron merged commit b6c23e1 into ros:noetic-devel Feb 11, 2021
jacobperron pushed a commit that referenced this pull request Apr 6, 2021
Fixes #2128

Fix bug "TypeError: not enough arguments for format string" in DeserializationError

Co-authored-by: 229143434@qq.com <zxcvbnm123-*@>
Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants