keep the persistent connection only if rosmaster supports http1.1 #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
fujitatomoya
approved these changes
Nov 30, 2021
|
@sloretz @jacobperron @mjcarroll friendly ping, requesting maintainer review. |
jacobperron
reviewed
Dec 2, 2021
| @@ -118,6 +118,9 @@ namespace XmlRpc { | |||
| // each thread should have its own client. | |||
| bool _executing; | |||
|
|
|||
| // True if the server supports HTTP1.1 | |||
| bool _server_http_1_1; | |||
There was a problem hiding this comment.
This change breaks ABI.
There was a problem hiding this comment.
but this breaks ABI.
our bad, that should be kept...sorry.
There was a problem hiding this comment.
I knew it breaks ABI, but it's clear.
I tried to use _connectionState, but some source code might be as
enum ClientConnectionState { NO_CONNECTION, CONNECTING, WRITE_REQUEST, READ_HEADER, READ_RESPONSE, IDLE,
CLIENT_CONNECT_STATE_MASK = 0xFFFF, SERVER_HTTP_DISCONNECT = 0x10000};
check header to set _connectionState:
_connectionState |= SERVER_HTTP_DISCONNECT;
set:
_connectionState = READ_HEADER;
-->
_connectionState |= READ_HEADER;
if (_connectionState == WRITE_REQUEST)
-->
if (_connectionState & CLIENT_CONNECT_STATE_MASK == WRITE_REQUEST)
check if SERVER_HTTP_DISCONNECT:
if (_connectionState & SERVER_HTTP_DISCONNECT)do you think it's acceptable?
It seems to not work fine.
There was a problem hiding this comment.
Do you have any other suggestions? I'd like to hear that.
…p1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
force-pushed
the
topic-server-not-support-http_1_1
branch
from
2a3f123
to
7750cc5
Compare
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
jacobperron
approved these changes
Dec 3, 2021
|
Should I take care of the Melodic backport? Or is it planned? |
I think a maintainer can include it in a backport PR, e.g. #2152 |
jacobperron
added a commit
that referenced
this pull request
Jan 25, 2022
) * keep the persistent connection only if rosmaster supports http1.1 Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Revert "keep the persistent connection only if rosmaster supports http1.1" This reverts commit 2cb7602. Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix without breaking ABI Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Update comment Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #2182
Signed-off-by: Chen Lihui lihui.chen@sony.com