Update topic_tools relay_field to Python 3 #2253
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves
Issue 2167
Content
Implementing the "unicode" to "bytes" migration the author of Issue 2167 describes.
After this change, Python's 2to3 only suggests
Explanation
To address the second half of issue #2167, it is the OP's example which is at fault, not relay_field. The example attempts to write a string to a field ("data") whose type has changed from "unicode" to "bytes" in Noetic. Replacing the empty string with empty brackets [] fixes that example. The example in the file's help looks intact.
Testing
On my copy of Noetic the attached example launch files run when the edit in this PR is made. Both show the frame_id being transferred but the timestamp changed to one second.
test_relay_field.tar.gz
I have not tested beyond these two examples.