Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

franka_ros: 0.7.1-2 in 'noetic/distribution.yaml' [bloom] #28920

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

fwalch
Copy link
Contributor

@fwalch fwalch commented Mar 31, 2021

Increasing version of package(s) in repository franka_ros to 0.7.1-2:

@fwalch fwalch requested a review from sloretz as a code owner March 31, 2021 15:27
@tfoote
Copy link
Member

tfoote commented Mar 31, 2021

This only has a debian increment change, but I see what appears to be upstream changes. Most of the time this will work but the correct thing to do is a patch release of the upstream content so that a new original tar ball is created, instead of overwriting the current one which has pitfalls relating to caching in the release pipeline.

@fwalch
Copy link
Contributor Author

fwalch commented Apr 1, 2021

The only change was that the noetic.ignored file was removed from the release repo. The 0.7.1 tag of the upstream repo franka_ros has not changed. Previously, we ignored some packages because a dependency had not been published yet, but this has recently been resolved (#28851).

@tfoote
Copy link
Member

tfoote commented Apr 2, 2021

ok great, that's reasonable for a debian increment. Thanks for the clarification.

@tfoote tfoote merged commit 5927d60 into ros:master Apr 2, 2021
@fwalch fwalch deleted the bloom-franka_ros-2 branch April 2, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants