Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neo_simulation2: 1.0.0-2 in 'galactic/distribution.yaml' [bloom] #30773

Closed

Conversation

padhupradheep
Copy link
Contributor

Increasing version of package(s) in repository neo_simulation2 to 1.0.0-2:

@mjeronimo
Copy link
Contributor

In the source repo, the version number in setup.py (0.0.0) doesn't match that in the package.xml (1.0.0). Also, a couple TODO items in setup.py.

@padhupradheep
Copy link
Contributor Author

padhupradheep commented Sep 21, 2021

Thanks for the comment. Is it okay if we do this update for the next release ? Because, we did not actually update the setup.py for the release in rolling as well, which was apparently made last week.

@wjwwood
Copy link
Member

wjwwood commented Sep 21, 2021

@padhupradheep I would recommend addressing it now, doing a 1.0.1 release, as having the versions mismatched can cause issues.

@wjwwood wjwwood added changes requested Maintainers have asked for changes to the pull request galactic labels Sep 21, 2021
@padhupradheep
Copy link
Contributor Author

Alright, thanks ! I will let you know once it is updated

@padhupradheep
Copy link
Contributor Author

padhupradheep commented Sep 22, 2021

Updated the version number in setup.py @wjwwood @mjeronimo . Let me know if there is something that I need to do further!

@jacobperron
Copy link
Contributor

@padhupradheep I think @wjwwood is suggesting to make a new release (1.0.1) and closing this PR. Then the release repo will also contain the change to the setup.py.

@padhupradheep
Copy link
Contributor Author

I also ran the bloom once again, so that the changes are applied to the release repos (Just skipped the PR). I thought that there will be a problem, once when we update the package to "1.0.1".

@padhupradheep I think @wjwwood is suggesting to make a new release (1.0.1) and closing this PR. Then the release repo will also contain the change to the setup.py.

Okay, I will then do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request galactic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants