-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real transition to TinyXML2? #24
Comments
I did a pretty extensive review of the use of the urdf APIs when coming up with #9. From what I saw, the majority of downstream users use |
Looks like you missed my point: The API has to use |
I see, I read it backwards. Sorry about that. Yeah, I could definitely get behind that proposal; deprecating the current |
@sloretz Ping. |
@sloretz, @clalancette: Unfortunately, we missed to cleanup the API of urdf and urdfdom and ultimately switch to TinyXML2 in Noetic. What are your plans regarding this? |
In short: remove tinyxml from https://github.com/ros2/urdf and https://github.com/ros2/urdfdom. It was already done for the former in ros2#17 , and we'll need to go through a deprecation/removal tick-tok cycle for the latter. |
Ok. So we should close this PR, right? |
Yeah, that would be my preference. Since we don't have another ROS 1 vehicle to deliver this, I don't see much of a way forward here. I'm going to close this out, thanks for working on it. |
I don't really understand #9, attempting to transition to TinyXML2.
Passing in a TinyXML document or element (version 1 or 2 doesn't matter) actually serializes into a string and calls
initString()
, which eventually parses the XML string again inparseURDF
. However, urdfdom's transition to TinyXML2 is still pending: ros/urdfdom#99.While the parsing from string is mandatory to allow for the Collada parser plugin, I don't really see why we should support the highly inefficient
initXml()
convenience methods at all in the future?Why not simply discourage their usage, i.e. deprecate them, and eventually remove them in future?
The text was updated successfully, but these errors were encountered: