-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unit test run with catkin_make run_tests
#15
Conversation
Catkin is already required, and requires python
I love the change. However, it looks like all CI has failed, with no yaml. I think we'll need to add python-yaml to the package.xml as well. |
Moved catkin_python_setup() after catkin_package()
A couple of things:
|
The unit tests can fail in some cases with catkin_make. When using catkin_make the unit tests cannot depend on an environment being set up with a complete environment (thankes @dirk-thomas!) This was not an issue with catkin_make_isolated or `catkin build`
@clalancette Will do with the package.xml! I learned from @dirk-thomas that unit tests can't expect to have the python path set up for importing python packages from the current package in all cases when using |
@clalancette I updated the package.xml. An odd thing is it has a |
I agree with you that the on python is a bit weird. However, there are other packages (vision_opencv, for instance), which also have that dependency. I'll leave it up to you, but I'd just leave it in for now; it probably doesn't hurt anything. Otherwise, I think this looks good to me, so feel free to merge it. |
I notice the unit tests wasn't running when using
catkin_make run_tests
. I changed how the test was added to use the catkin cmake macros. I also added python-mock as a test dependency because the official ubuntu/trusty docker image does not have that installed by default.