Remove gtest from the sources. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only used very sparingly, and gets rid of a vendored package that causes warnings. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
approved these changes
Apr 7, 2021
|
CI:
|
scpeters
approved these changes
Apr 7, 2021
|
feel free to merge |
This was referenced Apr 7, 2021
|
@clalancette can you please backport this to Foxy? Or at least the part indicated in #151 |
clalancette
added a commit
that referenced
this pull request
Apr 9, 2021
It is only used very sparingly, and gets rid of a vendored package that causes warnings. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
See #155 |
scpeters
pushed a commit
that referenced
this pull request
Aug 31, 2021
It is only used very sparingly, and gets rid of a vendored package that causes warnings. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only used very sparingly, and gets rid of a vendored
package that causes warnings.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
@scpeters @sloretz I'd appreciate review of this, as it will get rid of one of the long-standing warnings in ROS 2 CI: https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/750/clang/new/ .
Note that the other way we could go here is to update gtest to a newer version, but this seemed simpler to me.